Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RHELv2PackageInfo #928

Merged
merged 21 commits into from
Oct 18, 2022
Merged

Deprecate RHELv2PackageInfo #928

merged 21 commits into from
Oct 18, 2022

Conversation

RTann
Copy link
Collaborator

@RTann RTann commented Sep 12, 2022

There has only been a single RHELv2Package per RHELv2PackageInfo since Scanner 2.19.0 (see #456 for the related PR). Because of this, there is no real need for RHELv2PackageInfo any longer, so this PR deprecates it and removes all current usages of it. It is still required to exist to ensure we correctly diff older genesis dumps correctly. See the related changes in cmd/updater/diffdumps/rhelv2_diff.go.

Let's look at the two cases when we'd populate a RHELv2Vulnerability:

  1. Vuln dump generation
    • You can see here, for each criterion, we create a new RHELv2PackageInfo and add only a single RHELv2Package
  2. Vuln retrieval from the DB
    • You can see here, we only add a single RHELv2Package, pkg, to the single RHELv2PackageInfo entry for the vuln.

This PR deprecates RHELv2PackageInfo, adds the two fields FixedInVersion and ArchOperation to RHELv2Package, and ensures compatibility with previous genesis dumps by converting the old RHELv2PackageInfo into a modern RHELv2Package

@RTann RTann added the generate-dumps-on-pr Generates the image based on dumps from the PR label Sep 12, 2022
@ghost
Copy link

ghost commented Sep 12, 2022

Images are ready for the commit at 70c7be8.

To use the images, use the tag 2.26-62-g70c7be8d18.

@RTann
Copy link
Collaborator Author

RTann commented Oct 3, 2022

/retest

@RTann RTann requested a review from misberner October 13, 2022 16:54
Copy link
Contributor

@daynewlee daynewlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RTann RTann merged commit 4aec14b into master Oct 18, 2022
@RTann RTann deleted the ross/rm-pkg-infos branch October 18, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generate-dumps-on-pr Generates the image based on dumps from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants