-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate RHELv2PackageInfo #928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Images are ready for the commit at 70c7be8. To use the images, use the tag |
/retest |
daynewlee
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has only been a single
RHELv2Package
perRHELv2PackageInfo
since Scanner 2.19.0 (see #456 for the related PR). Because of this, there is no real need forRHELv2PackageInfo
any longer, so this PR deprecates it and removes all current usages of it. It is still required to exist to ensure we correctly diff older genesis dumps correctly. See the related changes incmd/updater/diffdumps/rhelv2_diff.go
.Let's look at the two cases when we'd populate a
RHELv2Vulnerability
:RHELv2PackageInfo
and add only a singleRHELv2Package
RHELv2Package
,pkg
, to the singleRHELv2PackageInfo
entry for the vuln.This PR deprecates
RHELv2PackageInfo
, adds the two fieldsFixedInVersion
andArchOperation
toRHELv2Package
, and ensures compatibility with previous genesis dumps by converting the oldRHELv2PackageInfo
into a modernRHELv2Package