ROX-27350: Use trusted tasks #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 12, 2024
This is paired with stackrox/scanner#1742 The idea is to unify determine-image-tag tasks for scanner and collector after that.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 12, 2024
and add notes to later unify with the StackRox one. Scanner can be unified with Collector thanks to stackrox/scanner#1742 It could be that the ultimate unification will come in https://issues.redhat.com/browse/ROX-26026 but I created a new task anyway.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 12, 2024
This is paired with stackrox/scanner#1742 The idea is to unify determine-image-tag tasks for scanner and collector after that.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 12, 2024
and add notes to later unify with the StackRox one. Scanner can be unified with Collector thanks to stackrox/scanner#1742 It could be that the ultimate unification will come in https://issues.redhat.com/browse/ROX-26026 but I created a new task anyway.
msugakov
force-pushed
the
misha/ROX-27350-use-trusted-tasks
branch
from
cdbee6c to
6914faa
Compare
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 12, 2024
This is paired with stackrox/scanner#1742 The idea is to unify determine-image-tag tasks for scanner and collector after that.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 12, 2024
and add notes to later unify with the StackRox one. Scanner can be unified with Collector thanks to stackrox/scanner#1742 It could be that the ultimate unification will come in https://issues.redhat.com/browse/ROX-26026 but I created a new task anyway.
msugakov
force-pushed
the
misha/ROX-27350-use-trusted-tasks
branch
2 times, most recently
from
13e98e6 to
fa545b5
Compare
|
/retest |
|
/retest scanner-on-push |
|
/retest |
msugakov
force-pushed
the
misha/ROX-27350-use-trusted-tasks
branch
from
789a5b8 to
494eae9
Compare
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 13, 2024
This is paired with stackrox/scanner#1742 The idea is to unify determine-image-tag tasks for scanner and collector after that.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 13, 2024
and add notes to later unify with the StackRox one. Scanner can be unified with Collector thanks to stackrox/scanner#1742 It could be that the ultimate unification will come in https://issues.redhat.com/browse/ROX-26026 but I created a new task anyway.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 13, 2024
This is paired with stackrox/scanner#1742 The idea is to unify determine-image-tag tasks for scanner and collector after that.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 13, 2024
and add notes to later unify with the StackRox one. Scanner can be unified with Collector thanks to stackrox/scanner#1742 It could be that the ultimate unification will come in https://issues.redhat.com/browse/ROX-26026 but I created a new task anyway.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 13, 2024
This is paired with stackrox/scanner#1742 The idea is to unify determine-image-tag tasks for scanner and collector after that.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 13, 2024
and add notes to later unify with the StackRox one. Scanner can be unified with Collector thanks to stackrox/scanner#1742 It could be that the ultimate unification will come in https://issues.redhat.com/browse/ROX-26026 but I created a new task anyway.
msugakov
force-pushed
the
misha/ROX-27350-use-trusted-tasks
branch
from
494eae9 to
2dcfbd5
Compare
|
/retest scanner-slim-on-push |
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 17, 2024
This is paired with stackrox/scanner#1742 The idea is to unify determine-image-tag tasks for scanner and collector after that.
msugakov
added a commit
to stackrox/konflux-tasks
that referenced
this pull request
Dec 17, 2024
and add notes to later unify with the StackRox one. Scanner can be unified with Collector thanks to stackrox/scanner#1742 It could be that the ultimate unification will come in https://issues.redhat.com/browse/ROX-26026 but I created a new task anyway.
in order to match the setup in other repositories and to be able to re-use shared tasks.
|
/retest scanner-db-on-push |
|
/retest scanner-db-on-push |
by using the bundle from stackrox/konflux-tasks#9
msugakov
force-pushed
the
misha/ROX-27350-use-trusted-tasks
branch
from
93df9a1 to
af2a4dc
Compare
msugakov
added
the
backport-for-4.6-konflux-release
|
/retest scanner-on-push |
|
/retest scanner-slim-on-push |
|
/retest scanner-on-push |
|
/retest scanner-on-push |
|
/retest scanner-slim-on-push |
|
/retest scanner-slim-on-push |
|
@msugakov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
tommartensen
approved these changes
Dec 20, 2024
| @@ -16,19 +16,19 @@ ENV CI=1 | |||
| COPY . /src | |||
| WORKDIR /src | |||
|
|
|||
| RUN scripts/konflux/fail-build-if-git-is-dirty.sh | |||
| RUN .konflux/scripts/fail-build-if-git-is-dirty.sh | |||
There was a problem hiding this comment.
We have this script in three different repositories. Can we run it as a separate task before build-container?
There was a problem hiding this comment.
Good idea to remove it from repos. Eventually this script only needed in determine-image-tag task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ROX-27480 is to follow up about moving fetch script.