Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-26094: variable blob location for Konflux #1684

Merged
merged 33 commits into from
Nov 14, 2024

Conversation

tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Oct 23, 2024

Idea:

  • SCANNER_TAG is passed from determine-image-tag
  • If it is not a tagged build, download data from latest
  • Else use the SCANNER_TAG

Hints

Validation:

New validation

TODO:

  • remove 0.0.0-test.x tags

Copy link

openshift-ci bot commented Oct 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tommartensen
Copy link
Contributor Author

/retest scanner-build

Copy link

openshift-ci bot commented Oct 23, 2024

@tommartensen: The /retest command does not accept any targets.
The following commands are available to trigger optional jobs:

  • /test e2e-tests
  • /test slim-e2e-tests

Use /test all to run all jobs.

In response to this:

/retest scanner-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tommartensen tommartensen added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Nov 11, 2024
@tommartensen tommartensen marked this pull request as ready for review November 13, 2024 08:56
@tommartensen tommartensen requested a review from a team as a code owner November 13, 2024 08:56
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic comments.

scripts/konflux/fetch-scanner-data.sh Outdated Show resolved Hide resolved
.tekton/scanner-build.yaml Show resolved Hide resolved
.tekton/scanner-db-build.yaml Show resolved Hide resolved
.tekton/fetch-scanner-data-task.yaml Outdated Show resolved Hide resolved
scripts/konflux/fetch-scanner-data.sh Outdated Show resolved Hide resolved
scripts/konflux/fetch-scanner-data.sh Outdated Show resolved Hide resolved
Copy link

openshift-ci bot commented Nov 14, 2024

@tommartensen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/slim-e2e-tests 4f124a3 link false /test slim-e2e-tests
ci/prow/e2e-tests 4f124a3 link false /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tommartensen
Copy link
Contributor Author

/retest scanner-slim-on-push

Copy link

openshift-ci bot commented Nov 14, 2024

@tommartensen: The /retest command does not accept any targets.
The following commands are available to trigger optional jobs:

  • /test e2e-tests
  • /test slim-e2e-tests

Use /test all to run all jobs.

In response to this:

/retest scanner-slim-on-push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tommartensen tommartensen merged commit 297b8d0 into master Nov 14, 2024
31 of 38 checks passed
@tommartensen tommartensen deleted the tm/ROX-26094-konflux-blob-locations branch November 14, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants