-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add tag resolution for jobs missing it #1570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we now need to cut a new release?
That's one option, OR, rename the files previously uploaded to use the proper tag (the latter being my preference) |
As long as you are sure the previous files have the right data, then that's fine with me |
Would be the same dump of data using in the tagged build: https://github.com/stackrox/scanner/actions/runs/9845637787 Taking a step back - makes me question the When we create a new scanner tag, we would have already created and added a genesis-dump reference to If that is accurate, that means the vulnerabilities embedded within an tagged image will be 'newer' then those referenced in |
The
upload-dumps-for-downstream
job did not upload bundles with the appropriate tag - breaking downstream builds.