fix(ci): handle release builds in GHA CI workflow #1561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our
tag
make target relies on theRELEASE_TAG
environment variable being set to the tag name when we perform a release build. Many of our scripts and processes rely onmake tag
outputting the current string (like the release version). We used to set this environment variable properly in OSCI due to:scanner/scripts/ci/lib.sh
Line 622 in 372710a
scanner/scripts/ci/lib.sh
Lines 696 to 706 in 372710a
For these changes, I copied the
stackrox/stackrox
pattern for handling tagged builds in our GitHub Action workflow, which was added in this PR: stackrox/stackrox#4239Note: This needs to be cherry-picked into the
release-2.34
branch.