Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-23123: Verifying File Integrity while updating offline bundle #1497

Merged
merged 4 commits into from
May 16, 2024
Merged

ROX-23123: Verifying File Integrity while updating offline bundle #1497

merged 4 commits into from
May 16, 2024

Conversation

daynewlee
Copy link
Contributor

No description provided.

@daynewlee daynewlee changed the title ROX-23123: Check download success or failure in the tmp folder ROX-23123: Check file validity in the tmp folder May 6, 2024
@daynewlee daynewlee changed the title ROX-23123: Check file validity in the tmp folder ROX-23123: Verifying File Integrity in the Temporary Folder May 6, 2024
@daynewlee daynewlee requested review from dcaravel, jvdm, RTann and BradLugo May 6, 2024 21:07
@daynewlee
Copy link
Contributor Author

daynewlee commented May 6, 2024 •
edited
Loading

Not sure if this is the most graceful way of doing things. Please let me know your suggestions and I will address the e2e test in another PR.

jvdm
jvdm reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@jvdm jvdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this?

jvdm
jvdm reviewed May 9, 2024
View reviewed changes
scripts/ci/jobs/diff-dumps.sh Outdated Show resolved Hide resolved
jvdm
jvdm reviewed May 9, 2024
View reviewed changes
scripts/ci/jobs/diff-dumps.sh Outdated Show resolved Hide resolved
@daynewlee daynewlee added the generate-dumps-on-pr Generates the image based on dumps from the PR label May 16, 2024
@daynewlee daynewlee force-pushed the yli3/fixBundleMissingError branch 2 times, most recently from 360081e to 5496ce7 Compare May 16, 2024 15:01
@daynewlee daynewlee changed the title ROX-23123: Verifying File Integrity in the Temporary Folder ROX-23123: Verifying File Integrity May 16, 2024
@daynewlee daynewlee requested a review from jvdm May 16, 2024 15:01
@daynewlee daynewlee changed the title ROX-23123: Verifying File Integrity ROX-23123: Verifying File Integrity while updating offline bundle May 16, 2024
jvdm
jvdm reviewed May 16, 2024
View reviewed changes
scripts/ci/jobs/diff-dumps.sh Outdated Show resolved Hide resolved
@daynewlee daynewlee force-pushed the yli3/fixBundleMissingError branch from 067893e to 890cd66 Compare May 16, 2024 18:53
@daynewlee daynewlee requested a review from jvdm May 16, 2024 18:53
@daynewlee
Copy link
Contributor Author

daynewlee commented May 16, 2024 •
edited
Loading

How did you test this?

I can only run the diff-dump job to see if the offline bundle is generated. But I think since the commands --fail flag and set -euo pipefail are in the script so we should be fine. Let me know what you think. @jvdm

jvdm
jvdm approved these changes May 16, 2024
View reviewed changes
scripts/ci/jobs/diff-dumps.sh Show resolved Hide resolved
@daynewlee @jvdm
Update scripts/ci/jobs/diff-dumps.sh
c8e666a 
Co-authored-by: J. Victor Martins <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 16, 2024

@daynewlee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/slim-e2e-tests c8e666a link false /test slim-e2e-tests
ci/prow/e2e-tests c8e666a link false /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@daynewlee daynewlee merged commit 83336e7 into master May 16, 2024
27 of 29 checks passed
@daynewlee daynewlee deleted the yli3/fixBundleMissingError branch May 16, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdm jvdm jvdm approved these changes

@dcaravel dcaravel Awaiting requested review from dcaravel

@RTann RTann Awaiting requested review from RTann

@BradLugo BradLugo Awaiting requested review from BradLugo

Assignees
No one assigned
Labels
generate-dumps-on-pr Generates the image based on dumps from the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daynewlee @jvdm