ROX-22889: Cherry pick new genesis dump into 2.32 (targeting ACS 4.3.7) #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are ready for the commit at 3c519b0. To use the images, use the tag |
jvdm
reviewed
Apr 25, 2024
Comment on lines
+450
to
+454
| { | ||
| "dumpLocationInGS": "gs://stackrox-scanner-ci-vuln-dump/genesis-20240228002053.zip", | ||
| "timestamp": "2024-02-28T00:20:53.211664833Z", | ||
| "uuid": "c73d1bf5-49cb-48cb-b475-46702de2be73" | ||
| }, |
There was a problem hiding this comment.
Curious: Was this missing by chance?
There was a problem hiding this comment.
I wouldn't say missing, believe that was from the ACS 4.4.0 release - As far as I can tell we do not typically update older releases with new genesis files (perhaps we should given we now know it can address corrected records). I figured add both records to avoid merge conflicts in case we have to do this again.
jvdm
approved these changes
Apr 25, 2024
|
cherry picked a handful of commits that update tests cases to get CI to pass |
This reverts commit 7ae7747.
RTann
approved these changes
Apr 25, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.