Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump stackrox/rox dep #1454

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

RTann
Copy link
Collaborator

@RTann RTann commented Mar 22, 2024

Bump this version in preparation for the future removal of pkg/bolthelper. stackrox/rox and stackrox/scanner unfortunately have a circular dependency, so I think it's best to try to catch up with the latest version of stackrox/rox before stackrox/rox catches up with stackrox/scanner.

This PR also bumps the minimum required go version to 1.19, as stackrox/rox requires this

@RTann RTann force-pushed the ross/bump-stackrox-stackrox-dep branch from 012470a to e15b389 Compare March 22, 2024 16:34
@RTann
Copy link
Collaborator Author

RTann commented Mar 22, 2024

Go 1.21 is kind of annoying. Maybe this PR should wait until stackrox/stackrox updates to go1.21

@RTann RTann force-pushed the ross/bump-stackrox-stackrox-dep branch 3 times, most recently from 63e4426 to 0284558 Compare March 27, 2024 21:55
@RTann
Copy link
Collaborator Author

RTann commented Mar 27, 2024

Depends on #1454

Copy link

@dashrews78 dashrews78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RTann RTann force-pushed the ross/bump-stackrox-stackrox-dep branch from 0284558 to 1af889e Compare April 2, 2024 17:26
@RTann RTann force-pushed the ross/bump-stackrox-stackrox-dep branch from 1af889e to a09707d Compare April 2, 2024 17:31
Copy link

openshift-ci bot commented Apr 2, 2024

@RTann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/slim-e2e-tests a09707d link false /test slim-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RTann RTann merged commit 64f875e into master Apr 2, 2024
17 of 18 checks passed
@RTann RTann deleted the ross/bump-stackrox-stackrox-dep branch April 2, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants