Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove timeutil package #1036

Merged
merged 1 commit into from
Dec 21, 2022
Merged

remove timeutil package #1036

merged 1 commit into from
Dec 21, 2022

Conversation

RTann
Copy link
Collaborator

@RTann RTann commented Dec 19, 2022

noticed this isn't used. No need for excess bloat in our repo/Go binary :)

@RTann RTann requested review from jvdm, daynewlee and dcaravel December 19, 2022 17:52
@ghost
Copy link

ghost commented Dec 19, 2022

Images are ready for the commit at 799cf3f.

To use the images, use the tag 2.27.x-12-g799cf3f85b.

@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2022

@RTann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 799cf3f link false /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@daynewlee daynewlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me but I am not sure if the e2e-test failures are related to this change.

@RTann RTann merged commit 7d181f3 into master Dec 21, 2022
@RTann RTann deleted the ross/rm-timeutil branch December 21, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants