ROX-12784: fix unpatched OpenShift 4 vulnerability detection #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTann
added
the
generate-dumps-on-pr
|
Images are ready for the commit at ef15cf7. To use the images, use the tag |
|
Verified the DB contains entries in |
daynewlee
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a single OpenShift 4 unpatched CVE file. This is in contrast to (*)most other products, which have a different unpatched file per minor version. The OpenShift 4 unpatched file indicates the affected CPE by a single, specific minor version, the next, unreleased version of OpenShift 4. It is implied this indicates each version of OpenShift 4 at that version and below are affected. For example, if the CPE is
cpe:/a:redhat:openshift:4.12, it is assumed versions 4.0 - 4.12 are all affected.Scanner performs RHEL-based image vulnerability matching by performing exact match queries with the CPEs found in the image and the CPEs indicated by the OVAL v2 feed. To fix the problem, this PR adds a CPE entry for the vulnerability for each OpenShift 4 minor version 4.0 <= x <= 4.y where y is the indicated minor version in the OVAL v2 feed. Originally, we only accounted for 4.y.
Note: there is a possibility the CPE format is changed to solely give the major version (ie
cpe:/a:redhat:openshift:4andcpe:/a:redhat:openshift:4::el8). This PR also accounts for this possibility.This solely affects unpatched OpenShift 4 vulnerabilities.
(*) RHEL also does this. However, the RHEL CPEs only indicate the major version. Because of this, we have never had a problem with RHEL. OpenShift's CPEs indicate the minor version, as well, which has proven to be a problem.