-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-27350: Fix update-tasks-trust
#7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa57faf
to
abe5327
Compare
/retest acs-konflux-tasks-on-push |
to see if we'll have accumulation in `rhacs-eng/konflux-tasks-trust` repo.
57bc8bf
to
76c2423
Compare
/retest acs-konflux-tasks-on-push |
Closed
tommartensen
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny request, rest LGTM.
https://everything.curl.dev/usingcurl/downloads/retry.html turned to be more helpful than curl's man.
tommartensen
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update-tasks-trust
failed in master push of #3 (see 5c84623 / https://github.com/stackrox/konflux-tasks/runs/34534649551).That's because it was the first attempt to push to
latest
tag which did not exist yet.The same did not happen in my PR #3 because when experimenting with
ec track bundle
I first used--output
argument and gotpr-3
tag allocated this way.This change should fix the problem.
Testing
CI here updates on the existing tag.

CI in a new branch pushed a new tag. TESTING FOR #7 #8
