Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-27350: Fix update-tasks-trust #7

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Dec 17, 2024

update-tasks-trust failed in master push of #3 (see 5c84623 / https://github.com/stackrox/konflux-tasks/runs/34534649551).

time="2024-12-17T13:16:36Z" level=debug msg="globalTimeout is 300000000000" func=func1 file=" root_cmd.go:80"
Error: GET https://quay.io/v2/rhacs-eng/konflux-tasks-trust/manifests/latest: MANIFEST_UNKNOWN: manifest unknown; map[]

That's because it was the first attempt to push to latest tag which did not exist yet.

The same did not happen in my PR #3 because when experimenting with ec track bundle I first used --output argument and got pr-3 tag allocated this way.

This change should fix the problem.

Testing

  1. CI here updates on the existing tag.
    image

  2. CI in a new branch pushed a new tag. TESTING FOR #7 #8
    image

@msugakov msugakov force-pushed the misha/ROX-27350-fix-trust-update branch from fa57faf to abe5327 Compare December 17, 2024 14:54
@msugakov
Copy link
Contributor Author

/retest acs-konflux-tasks-on-push

to see if we'll have accumulation in `rhacs-eng/konflux-tasks-trust`
repo.
@msugakov msugakov force-pushed the misha/ROX-27350-fix-trust-update branch from 57bc8bf to 76c2423 Compare December 17, 2024 15:15
@msugakov
Copy link
Contributor Author

/retest acs-konflux-tasks-on-push

msugakov added a commit that referenced this pull request Dec 17, 2024
@msugakov msugakov mentioned this pull request Dec 17, 2024
@msugakov msugakov marked this pull request as ready for review December 17, 2024 15:28
@msugakov msugakov requested a review from a team as a code owner December 17, 2024 15:28
Copy link
Contributor

@tommartensen tommartensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny request, rest LGTM.

.tekton/acs-konflux-tasks-push.yaml Show resolved Hide resolved
@msugakov msugakov merged commit f5c916a into main Dec 18, 2024
1 check passed
@msugakov msugakov deleted the misha/ROX-27350-fix-trust-update branch December 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants