Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration tests on konflux built images #1691

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented May 29, 2024

Description

Since konflux seems to be coming along quite nicely and the recent changes have made it so only one image is built for it, it seems like a good moment to start properly testing the images in our CI. With this change tests will be run on the konflux built images on master, tags and PRs for branches that contain the words konflux or rhtap.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

  • Tests are run with the -fast images on PRs. CI run
  • Tests are run with the -fast images on branch pushes. CI run
  • Tests are run with the -fast images on tag pushes. CI run

Try different branch filter

Finer control on when konflux tests run

Debug

Fix colliding concurrency group

Fix if condition

Singular... Image

Remove debug job

Deep fetch

Fix quotes

Use the correct tag everywhere

Tag format, maybe?

Add k8s based tests

Checkout head branch on PRs

Fix collector-qa-tag

Use rhacs-eng image for k8s based tests

Test push actions

Make PR testing easier

Properly wait for the integration tests containers

Exclude multiarch builds from konflux tests
@Molter73 Molter73 force-pushed the mauro/ROX-24427-test-konflux-images branch from e075745 to 596d505 Compare June 4, 2024 09:03
@Molter73 Molter73 changed the title Run the basic set of integration tests on konflux built images Run integration tests on konflux built images Jun 4, 2024
@Molter73 Molter73 added the run-multiarch-builds Run steps for non-x86 archs. label Jun 4, 2024
@Molter73 Molter73 marked this pull request as ready for review June 4, 2024 10:10
@Molter73 Molter73 requested a review from a team as a code owner June 4, 2024 10:10
@Molter73 Molter73 merged commit 9041791 into master Jun 4, 2024
75 of 76 checks passed
@Molter73 Molter73 deleted the mauro/ROX-24427-test-konflux-images branch June 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants