ROX-20232: Reduce duplication in Collector Konflux pipelines #1676
Conversation
msugakov
changed the title
msugakov
force-pushed
the
misha/ROX-20232-groom-collector-konflux-pipelines
branch
2 times, most recently
from
0316110 to
e8dd121
Compare
|
/retest |
msugakov
force-pushed
the
misha/ROX-20232-groom-collector-konflux-pipelines
branch
from
e8dd121 to
46e03ef
Compare
Just used an IDE command, no other manual changes.
and use it everywhere.
Only used IDE command, no manual changes on top.
msugakov
force-pushed
the
misha/ROX-20232-groom-collector-konflux-pipelines
branch
from
46e03ef to
7ebd9e4
Compare
|
/retest |
| - name: TARGET_STAGE | ||
| value: $(params.build-target-stage) | ||
| runAfter: | ||
| - prefetch-dependencies |
There was a problem hiding this comment.
This seems to be slightly different from the original version, where prefetch-dependencies was run after prepare-rhel-rpm-subscriptions. Just out of curiosity, is the order here important?
There was a problem hiding this comment.
The order matters in general but not here.
Both prefetch-dependencies and prepare-rhel-rpm-subscriptions (as well as earlier clone-repository and determine-image-tag) are prerequisites for build-container. They were put sequentially because, well, we could. They can also be put parallel because they don't have a dependency on each other.
In fact, in .tekton/collector-(pull-request|push).yaml they were already in parallel and this caused no issue.
.tekton/collector-slim-(pull-request|push).yaml were simply not made consistent.
There was a problem hiding this comment.
BTW, getting rid of these discrepancies was a side-goal of the task.
|
/retest |
1 similar comment
|
/retest |
|
Finally, green enough Konflux CI. Merging. |
Description
Follows the pattern set in stackrox/stackrox#10866.
YAML formatting applied from stackrox/scanner#1515.
It's best to review this change by commits where I tried supplying meaningful messages.
Checklist
[ ] Updated documentation accordinglyAutomated testing
[ ] Added unit tests[ ] Added integration tests[ ] Added regression testsIf any of these don't apply, please comment below.Testing Performed
Only looking at CI.