Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-25719: Runtime control channel #1627

Closed
wants to merge 8 commits into from

Conversation

ovalenti
Copy link
Contributor

@ovalenti ovalenti commented Apr 5, 2024

Description

Collector needs a new grpc API to manage its configuration dynamically, in particular for runtime-filtering.

We propose an approach similar to the iSensor service, where a bi-directional stream is opened on top of a single grpc method. Then multiple object types can flow in each direction by making them part of a oneof list containing all off them.

The main messages should be aimed at:

  • exchange capabilities.
  • set the initial filtering and update it at any time.
  • retrieve statistics and troubleshooting information.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

@ovalenti ovalenti self-assigned this Apr 5, 2024
@ovalenti ovalenti force-pushed the ovalenti/collector_control_channel branch from a9fa93b to 69436e3 Compare April 22, 2024 16:01
@ovalenti ovalenti force-pushed the ovalenti/collector_control_channel branch from 5cf44da to 523ccb0 Compare April 25, 2024 08:27
@ovalenti ovalenti force-pushed the ovalenti/collector_control_channel branch from c3113f4 to 22db5a0 Compare May 13, 2024 16:35
@ovalenti ovalenti force-pushed the ovalenti/collector_control_channel branch from 22db5a0 to 82a6293 Compare May 13, 2024 16:43
@ovalenti ovalenti changed the title Runtime control channel ROX-25719: Runtime control channel Aug 12, 2024
@ovalenti ovalenti closed this Sep 26, 2024
@ovalenti ovalenti deleted the ovalenti/collector_control_channel branch October 31, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants