-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-25719: Runtime control channel #1627
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovalenti
force-pushed
the
ovalenti/collector_control_channel
branch
from
April 22, 2024 16:01
a9fa93b
to
69436e3
Compare
ovalenti
force-pushed
the
ovalenti/collector_control_channel
branch
from
April 25, 2024 08:27
5cf44da
to
523ccb0
Compare
ovalenti
force-pushed
the
ovalenti/collector_control_channel
branch
from
May 13, 2024 16:35
c3113f4
to
22db5a0
Compare
ovalenti
force-pushed
the
ovalenti/collector_control_channel
branch
from
May 13, 2024 16:43
22db5a0
to
82a6293
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Collector needs a new grpc API to manage its configuration dynamically, in particular for runtime-filtering.
We propose an approach similar to the iSensor service, where a bi-directional stream is opened on top of a single grpc method. Then multiple object types can flow in each direction by making them part of a oneof list containing all off them.
The main messages should be aimed at:
Checklist
Automated testing