changed server_address defaults

stackql · Oct 15, 2023 · e127bc2 · e127bc2
1 parent f80c780
commit e127bc2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/.github/workflows/async_server_tests.yaml b/.github/workflows/async_server_tests.yaml
@@ -10,7 +10,7 @@ jobs:
       matrix:
         os:
           - ubuntu-latest
-          # - windows-latest
+          - windows-latest
           - macos-latest
         python-version:
           - "3.7"
@@ -19,11 +19,9 @@ jobs:
           - "3.10"
           - "3.11"
           - "3.12"
-        exclude:
-          - os: windows-latest
-            python-version: "3.12"
-          # - os: ubuntu-latest
-          #   python-version: "3.12"            
+        # exclude:
+        #   - os: windows-latest
+        #     python-version: "3.12"
     runs-on: ${{matrix.os}}
     name: 'Run Tests on ${{matrix.os}} with Python ${{matrix.python-version}}'
 

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -19,9 +19,9 @@ jobs:
           - "3.10"
           - "3.11"
           - "3.12"
-        exclude:
-          - os: windows-latest
-            python-version: "3.12"
+        # exclude:
+        #   - os: windows-latest
+        #     python-version: "3.12"
     runs-on: ${{matrix.os}}
     name: 'Run Tests on ${{matrix.os}} with Python ${{matrix.python-version}}'
 

diff --git a/pystackql/stackql.py b/pystackql/stackql.py
@@ -22,7 +22,7 @@ class StackQL:
 	
 	server_address: The address of the StackQL server (server_mode only).
 		:type server_address: str
-		:default: '0.0.0.0'
+		:default: '127.0.0.1'
 	
 	server_port: The port of the StackQL server (server_mode only).
 		:type server_port: int
@@ -264,8 +264,6 @@ def __init__(self,
 
 		if self.server_mode:
 			# server mode, connect to a server via the postgres wire protocol
-			if this_os == 'Windows':
-				server_address = '127.0.0.1'
 			self.server_address = server_address
 			self.server_port = server_port
    			# establish the connection