Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pulp/dnf roles to avoid having to redefine Ark URLs #507

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Refactor pulp/dnf roles to avoid having to redefine Ark URLs #507

merged 4 commits into from
Jan 2, 2025

Conversation

wtripp180901
Copy link
Contributor

@wtripp180901 wtripp180901 commented Dec 19, 2024 •
edited
Loading

Pulp URL subpaths now keyed by version in appliances_pulp_repos

Tested locally

@wtripp180901 wtripp180901 requested a review from a team as a code owner December 19, 2024 12:39
@sjpb sjpb changed the title Refactored pulp/dnf roles to avoid having to redefine Ark URLs Refactor pulp/dnf roles to avoid having to redefine Ark URLs Dec 19, 2024
sjpb
sjpb requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks for linting and explanation only

ansible/roles/pulp_site/defaults/main.yml Outdated Show resolved Hide resolved
ansible/filter_plugins/utils.py Show resolved Hide resolved
ansible/filter_plugins/utils.py Outdated Show resolved Hide resolved
@wtripp180901 @sjpb
Review linting changes
ada3dc9 
Co-authored-by: Steve Brasier <[email protected]>
@wtripp180901 wtripp180901 requested a review from sjpb January 2, 2025 09:55
sjpb
sjpb approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wtripp180901
Copy link
Contributor Author

fatimage for sanity (don't need to bump) https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12580610120

@wtripp180901 wtripp180901 merged commit 20cc4ab into main Jan 2, 2025
2 of 4 checks passed
@wtripp180901 wtripp180901 deleted the refactor/pulp-urls branch January 2, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtripp180901 @sjpb