Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't link manila for /home to manila for /project in caas #363

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Feb 21, 2024

Enables making the use of manila for /home in CaaS clusters an explicit opt-in via azimuth-ops configuration. This is to avoid the current situation where:

  1. Deploy vanilla Azimuth
  2. Deploy a Slurm cluster, gets Cinder home
  3. Enable the project share support in Azimuth
  4. Patch the Slurm cluster - existing data in /home gets deleted

@sjpb sjpb requested a review from a team as a code owner February 21, 2024 09:30
Copy link
Member

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb
Copy link
Collaborator Author

sjpb commented Feb 21, 2024

Testing at this commit:

  • Created azimuth without setting azimuth_openstack_manila_project_share_gb
  • Created slurm had no /project and /home was cinder - correct
  • Reprovisioned azimuth with azimuth_openstack_manila_project_share_gb: 10
  • New slurm had /project but /home was still cinder - correct

@sjpb sjpb merged commit 74ca684 into main Feb 21, 2024
1 check passed
@sjpb sjpb deleted the fix/caas-cinder-home branch February 21, 2024 14:20
@mkjpryor
Copy link
Member

I have also verified that the following works:

  1. Created azimuth without setting azimuth_openstack_manila_project_share_gb
  2. Created slurm had no /project and /home was cinder - correct
  3. Reprovisioned azimuth with azimuth_openstack_manila_project_share_gb: 10
  4. Update of existing slurm picks up /project but /home was still cinder - correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants