Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure when setting basic_users state: absent #361

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Feb 17, 2024

At some point loginctl format changed to include extra fields, some of which may be empty. Luckily we only care about the first two so don't have to parse this properly.

[rocky@demo-login-0 ~]$ loginctl list-sessions
SESSION  UID USER  SEAT TTY   IDLE SINCE
   1789 1000 rocky      pts/0 no        
   1796 1000 rocky      n/a   no        
   1797 1006 lab0       pts/1 no  

@sjpb sjpb requested a review from a team as a code owner February 17, 2024 09:29
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as-is, so I don't see the point in fussing about the methodology, though I've a minor comment on the use of JSON.

Approved, but also happy to re-review if you want to update to address the comment.

@sjpb sjpb force-pushed the fix/basic_user_removal branch from 69c967d to 9f7287a Compare February 20, 2024 11:19
@sjpb sjpb merged commit 4801c83 into main Feb 20, 2024
1 check failed
@sjpb sjpb deleted the fix/basic_user_removal branch February 20, 2024 11:19
@sjpb sjpb added the bug Something isn't working label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants