New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore image changes in skeleton terraform lifecycle #334

Merged

sjpb merged 1 commit into main from feat/image-lifecycle

Dec 7, 2023

Collaborator

sjpb commented Nov 29, 2023

Allows the skeleton terraform to act on image changes. This is because:

Now state is not in the root disk, being able to reimage with terraform is useful, especially for development.
No one is using slurm-controlled reimage (which conflicts with terraform tracking compute node usage)
For the control node, there are issues around lifecycle due to the root disk block device definition also referencing the image.
For production non-Azimuth use, any change to lifecycle needs some careful consideration anyway.


          don't ignore image changes for TF

eb4e907

sjpb force-pushed the feat/image-lifecycle branch from df45977 to eb4e907 Compare

December 7, 2023 13:21

sjpb marked this pull request as ready for review

December 7, 2023 13:22

sjpb requested a review from a team as a code owner

December 7, 2023 13:22

sd109 approved these changes

View reviewed changes

Member

sd109 left a comment

LGTM

sjpb merged commit c18dbd5 into main

1 check passed

sjpb deleted the feat/image-lifecycle branch

December 7, 2023 16:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet