Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #73: Fails late if no secrets defined #329

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Fix #73: Fails late if no secrets defined #329

merged 4 commits into from
Dec 1, 2023

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Nov 24, 2023 •
edited
Loading

fixes #73

@sjpb sjpb marked this pull request as ready for review November 28, 2023 15:39
@sjpb sjpb requested a review from a team as a code owner November 28, 2023 15:39
sd109
sd109 previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ansible/roles/passwords/tasks/validate.yml Outdated Show resolved Hide resolved
@sjpb @sd109
Improve fail message
251409b 
Co-authored-by: Scott Davidson <[email protected]>
@sjpb sjpb requested a review from sd109 November 29, 2023 16:45
@sjpb sjpb merged commit 27b6e3b into main Dec 1, 2023
1 check passed
@sjpb sjpb deleted the fix/73 branch December 1, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sd109 sd109 sd109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails late if no secrets defined
2 participants
@sjpb @sd109