Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo_site.bzl: remove use of FileType function #9

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

robfig
Copy link
Contributor

@robfig robfig commented Apr 24, 2019

It was disabled by default as of Bazel 0.24:
https://blog.bazel.build/2019/03/26/bazel-0.24.html
bazelbuild/bazel#5831

The resulting error message is:

ERROR: /home/circleci/.cache/bazel/_bazel_circleci/f16e36219ef33c22efc2ad20f3e3775c/external/build_stack_rules_hugo/hugo/internal/hugo_site.bzl:88:27: Traceback (most recent call last):
File "/home/circleci/.cache/bazel/_bazel_circleci/f16e36219ef33c22efc2ad20f3e3775c/external/build_stack_rules_hugo/hugo/internal/hugo_site.bzl", line 83
	rule(implementation = _hugo_site_impl, ...)})
File "/home/circleci/.cache/bazel/_bazel_circleci/f16e36219ef33c22efc2ad20f3e3775c/external/build_stack_rules_hugo/hugo/internal/hugo_site.bzl", line 87, in rule
	attr.label(allow_files = FileType([".toml",..."]), <2 more arguments>)
File "/home/circleci/.cache/bazel/_bazel_circleci/f16e36219ef33c22efc2ad20f3e3775c/external/build_stack_rules_hugo/hugo/internal/hugo_site.bzl", line 88, in attr.label
	FileType([".toml", ".yaml", ".json"])
FileType function is not available. You may use a list of strings instead. You can temporarily reenable the function by passing the flag --incompatible_disallow_filetype=false

For this filtering to a set of extensions, a simple string list will do.

It was disabled by default as of Bazel 0.24:
https://blog.bazel.build/2019/03/26/bazel-0.24.html
bazelbuild/bazel#5831

The resulting error message is:

    ERROR: /home/circleci/.cache/bazel/_bazel_circleci/f16e36219ef33c22efc2ad20f3e3775c/external/build_stack_rules_hugo/hugo/internal/hugo_site.bzl:88:27: Traceback (most recent call last):
	File "/home/circleci/.cache/bazel/_bazel_circleci/f16e36219ef33c22efc2ad20f3e3775c/external/build_stack_rules_hugo/hugo/internal/hugo_site.bzl", line 83
		rule(implementation = _hugo_site_impl, ...)})
	File "/home/circleci/.cache/bazel/_bazel_circleci/f16e36219ef33c22efc2ad20f3e3775c/external/build_stack_rules_hugo/hugo/internal/hugo_site.bzl", line 87, in rule
		attr.label(allow_files = FileType([".toml",..."]), <2 more arguments>)
	File "/home/circleci/.cache/bazel/_bazel_circleci/f16e36219ef33c22efc2ad20f3e3775c/external/build_stack_rules_hugo/hugo/internal/hugo_site.bzl", line 88, in attr.label
		FileType([".toml", ".yaml", ".json"])
    FileType function is not available. You may use a list of strings instead. You can temporarily reenable the function by passing the flag --incompatible_disallow_filetype=false

For this filtering to a set of extensions, a simple string list will do.
@pcj
Copy link
Member

pcj commented Apr 25, 2019

Thank you @robfig

@pcj pcj merged commit 08d312f into stackb:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants