Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

[Merged by Bors] - Parameterize stacks and migrate logging and monitoring stack #228

Closed
wants to merge 65 commits into from
Closed

[Merged by Bors] - Parameterize stacks and migrate logging and monitoring stack #228

wants to merge 65 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Feb 13, 2023 •
edited
Loading

Description

Fixes stackabletech/issues#319, #193

  • Demos and stacks can now be parametrized.
  • Monitoring and logging stack added as well as parametrized.
  • All the other stacks and demos are migrated to v2, but are not parametrized yet to reduce the scope of this PR

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer
Inital implementation for parameterization of stacks
2009f2d
@sbernauer
Add logging stack
074d6a9
@sbernauer
Merge remote-tracking branch 'origin/main' into parameterize-stacks
a377474
@sbernauer
Use pvcs for Prom + Grafana
481e03f
@sbernauer
Load Dashboards from CM
27ae2b3
@sbernauer
Add MinIO dashboard
14938f5
@sbernauer
Add Kafka dashboard
052617d
@sbernauer
Add Zookeeper dashboard
7e992ce
@sbernauer
Escape Grafana dashboards
933249d
@sbernauer
Fix tera template folder
c44b2ba
@sbernauer
Merge remote-tracking branch 'origin/main' into parameterize-stacks
7807563
@sbernauer
Add HDFS dashboard
2fe3ce5
@sbernauer
Update Trino dashboard
ac1ebf3
@sbernauer
Add NiFi
2289f54
@sbernauer
Update Kafka
0c7abb5
@sbernauer
Use correct memory metric
c48492b
@sbernauer
Give Prom larger pvc
6247939
@sbernauer
Add topic metrics to Kafka dashboard
6be6b49
@sbernauer
Dashboard range 3h
b4fbbe7
@sbernauer
Update Kafka dashboard
87c89d5
@sbernauer
Use correct rate
5a33b04
@sbernauer
collect pv and pvc labels
3b5152c
@sbernauer
Improve kafka
6fa1e91
@sbernauer
Remove hdfs + zk
1d87f4b
@sbernauer
Update trino
f25f757
@sbernauer
Add product variable
84f8af3
@sbernauer
add hdfs
a18cbb5
@sbernauer
Improve HDFS
f61f648
@sbernauer
Add hbase
26ade72
@sbernauer
fix colors
db95562
maltesander
maltesander suggested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some nit picking. Did not test yet.

sbernauer and others added 2 commits February 13, 2023 14:20
@sbernauer @maltesander
Update src/demo.rs
1200c5b 
Co-authored-by: Malte Sander <[email protected]>
@sbernauer @maltesander
Update src/stack.rs
a71a0a0 
Co-authored-by: Malte Sander <[email protected]>
maltesander
maltesander reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging Demo and Monitoring Stack work fine! Setting parameters works.
Changelog is missing.
LGTM otherwise.

sbernauer
sbernauer commented Feb 13, 2023
View reviewed changes
maltesander
maltesander approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 14, 2023
@sbernauer
Parameterize stacks and migrate logging and monitoring stack (#228)
87c3fcf 
## Description

* Demos and stacks can now be parametrized.
* Monitoring and logging stack added as well as parametrized.
* All the other stacks and demos are migrated to v2, but are *not* parametrized yet to reduce the scope of this PR
@bors
Copy link

bors bot commented Feb 14, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Parameterize stacks and migrate logging and monitoring stack [Merged by Bors] - Parameterize stacks and migrate logging and monitoring stack Feb 14, 2023
@bors bors bot closed this Feb 14, 2023
@bors bors bot deleted the parameterize-stacks branch February 14, 2023 11:51
This was referenced Feb 15, 2023
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@maltesander maltesander

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product monitoring: Create stack installing Prometheus + Servicemonitor + Grafana
2 participants
@sbernauer @maltesander