Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Migrate to maven #61

Closed
wants to merge 9 commits into from
Closed

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Nov 14, 2022

Description

This will fix #3

Also incrementing the version by one, and moving from de.stackable prefix to tech.stackable prefix.

Test run: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/40/

The test uses a custom image that includes this new version of the plugin

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@fhennig fhennig marked this pull request as ready for review November 15, 2022 14:21
@fhennig fhennig requested a review from maltesander November 15, 2022 14:32
- name: Set up OpenPolicyAgent
run: |
curl -L -o opa https://openpolicyagent.org/downloads/v0.33.1/opa_linux_amd64_static
curl -L -o opa https://openpolicyagent.org/downloads/v0.46.1/opa_linux_amd64_static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that i see this. We only support OPA up to 0.45.0 i think. Eventually we should check against versions we support?

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig
Copy link
Contributor Author

fhennig commented Nov 15, 2022

bors merge

bors bot pushed a commit that referenced this pull request Nov 15, 2022
## Description

This will fix #3 

Also incrementing the version by one, and moving from `de.stackable` prefix to `tech.stackable` prefix.

Test run: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/40/

The test uses a custom image that includes this new version of the plugin
@bors
Copy link

bors bot commented Nov 15, 2022

Pull request successfully merged into main.

Build succeeded:

  • build

@bors bors bot changed the title Migrate to maven [Merged by Bors] - Migrate to maven Nov 15, 2022
@bors bors bot closed this Nov 15, 2022
@bors bors bot deleted the migrate-to-maven branch November 15, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert build system to Maven
2 participants