-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add observability stack with jaeger and opentelemetry-collector #35
Conversation
…rvability stack directory
…nfigured data sources and TLS
Just on very high level comment, because I was working on integrating openobserve into the demos somewhere else, which would in theory also support OpenTelemetry I believe. Is it maybe worth taking a brief look at what Jaeger gives us more than OpenObserve? If OpenObserve suffices, we'd have one tool to take care of logs, metrics and traces all in one fell swoop for the demos .. |
I've gone with the Grafana stack as it has been IMO the best all-round observability stack. At this point in time, only the stack exists, so it wasn't described, but my intention is that a demo would explain all of this. |
…d template variable
This is basically done, but I was waiting on a couple of changes to go into stackable-webhooks/stackable-telemetry (see task list in stackabletech/issues#531) to ensure a problem wasn't being created by the opentelemetry-collector. I have some local changes/clean up to finalize this (I aim to do that after my holiday). Note It is only a stack at this point, and not an entire demo (that is best left to when we have instrumented real webhooks/operators and/or enabled instrumentation on products). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please expose using NodePorts
- Deploy collector Pod (and not only sidecars)
- URLs in stacks.yaml need updating (just before merging)
I have done so for Grafana (b690482), but am unable to do the same for the OpenTelemetry Collector (see open-telemetry/opentelemetry-operator#902).
Done in d9336f2
Done in 8bea6ae |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please add a comment everywhere you were not able to use a NodePort including the link to the issue if possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Done in d8c58d0 |
Make a Stack to aid in development and validation of webhook telemetry (and beyond). This will evolve into a full demo when operators/webhooks and/or products have been instrumented.
Stack
Deploy an instrumented operator with a webhookDemo
Important
A demo is not included for now, because there is no operator/webhook that has been instrumented yet. This can be done in a future PR.