You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/// \param[out] J A reference on the Jacobian matrix where the results will be stored in (dim 6 x
/// model.nv). You must fill J with zero elements, e.g. J.setZero().
What could be done to smooth the user experience ?
I was thinking, as a first step, to add asserts in those methods to check in debug that the parameter in indeed set to 0.
Do you want me to open a PR ?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hello,
I realized recently that some methods expect the ouptut parameter to be initialized to 0. Such as:
pinocchio/include/pinocchio/algorithm/jacobian.hpp
Line 173 in 187afaf
I don't think it is very obvious for the user since it's only said once in the middle of a long docstring:
pinocchio/include/pinocchio/algorithm/rnea-second-order-derivatives.hpp
Lines 13 to 70 in 187afaf
Moreover, the way to say it is not always consistent between every function that requires it. (For instance, here is slightly different: )
pinocchio/include/pinocchio/algorithm/jacobian.hpp
Lines 152 to 153 in 187afaf
What could be done to smooth the user experience ?
I was thinking, as a first step, to add asserts in those methods to check in debug that the parameter in indeed set to 0.
Do you want me to open a PR ?
Beta Was this translation helpful? Give feedback.
All reactions