Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove psycopg2 dependencies #15

Merged
merged 2 commits into from
Sep 15, 2021
Merged

remove psycopg2 dependencies #15

merged 2 commits into from
Sep 15, 2021

Conversation

vincentsarago
Copy link
Member

closes #12

cc @kylebarron

kylebarron
kylebarron approved these changes Sep 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@vincentsarago @kylebarron
Update README.md
8d781e1 
Co-authored-by: Kyle Barron <[email protected]>
@vincentsarago vincentsarago merged commit d271790 into master Sep 15, 2021
@vincentsarago vincentsarago deleted the optionalpsycopg2 branch September 15, 2021 19:02
@drnextgis
Copy link
Contributor

Does it make sense to replace:

RUN cd /tmp && pip install . --no-cache-dir

with

RUN cd /tmp && pip install .[psycopg2-binary] --no-cache-dir

in Dockerfile?

@vincentsarago
Copy link
Member Author

good catch @drnextgis

Because the base docker comes with postgres lib we don't have to use [psycopg2-binary] but [binary]. Feel free to start a PR 🙏

@drnextgis
Copy link
Contributor

Do you mean [psycopg2] like it is defined here?

@vincentsarago
Copy link
Member Author

🤦 Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

psycopg2 or psycopg2-binary
3 participants
@vincentsarago @drnextgis @kylebarron