-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Collection Search Extension #681
Conversation
…earch-to-dynamic-stac-api Added collection search extension
…llection-search Bugfix/json response type error collection search
…llections and items
The collection search extension adds two endpoints which allow searching of | ||
collections via GET and POST: | ||
GET /collection-search | ||
POST /collection-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add a note that the extension seems to mention GET /collections
and POST /collections
but due to possible conflict with the transaction
extension we should to use /collection-search
also wonder if we should use /collections-search
or /search/collections
🤷♂️
…e-discovery-level-search-api Feature/eodhp 27 resource catalogue discovery level search api
@@ -175,7 +177,7 @@ def register_get_item(self): | |||
""" | |||
self.router.add_api_route( | |||
name="Get Item", | |||
path="/collections/{collection_id}/items/{item_id}", | |||
path="/catalogs/{catalog_id}collections/{collection_id}/items/{item_id}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬 maybe this change wasn't made on purpose?
…lection-endpoint Corrected endpoint path for create collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't implement https://github.com/stac-api-extensions/collection-search
The extension doesn't define a POST /collections endpoint, only GET /collections. The endpoint names are wrong.
All functionality in OGC API - Records - Part 1: Local Resource Catalogue is only defined for the GET method (i.e. GET /collections). Note: STAC may add behavior for POST /collections in the future, but due to a potential conflict with the Transaction Extension, specific rules for content negotiation might be required.
Thanks for your comments @vincentsarago and @m-mohr, this PR has become mixed up with subsequent commits, I will raise a new one only containing the updates for the collection search extension - see draft PR #693 |
Related Issue(s): #615
Description: Adding Collection Search Extension as defined here
PR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)