Update request body types for Transaction Extension spec and client #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A POST against an items endpoint should accept an Item or ItemCollection https://github.com/radiantearth/stac-api-spec/blob/master/ogcapi-features/extensions/transaction/README.md#methods Add literal values to the stac_types `type` attribute in order to allow fastapi a discriminator value for parsing the request body to the correct TypedDict.
4 tasks
gadomski
approved these changes
May 12, 2023
There was a problem hiding this comment.
@mmcfarland LGTM. I added a pretty basic smoke test, I don't think it actually exercises much (maybe some of the typing changes) but it at least demonstrates what we're trying to do? Do you mind taking a look at the test and seeing if it makes sense and if you think it has any value?
It doesn't exercise much, but at least it demonstrates what we're trying to do.
gadomski
force-pushed
the
mjm/transaction-create-itemcollection
branch
from
e33a3af to
d7e2c65
Compare
|
Thanks @gadomski I think it definitely adds value. I ran the test against main and got the expected failures. Thanks for the assist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A POST against an items endpoint should accept an Item or ItemCollection
https://github.com/radiantearth/stac-api-spec/blob/master/ogcapi-features/extensions/transaction/README.md#methods
Added literal values to the stac_types
typeattribute in order to allow fastapi a discriminator value for parsing the request body to the correct TypedDict. Without this change, ItemCollections were parsed as Items and lost thefeaturesattribute.PR Checklist:
pre-commithooks pass locallymake test)make docs)