Return added Item/Collection in Transactions response #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckontheweb
commented
Jul 19, 2022
duckontheweb
added a commit
that referenced
this pull request
Jul 19, 2022
duckontheweb
added a commit
that referenced
this pull request
Jul 21, 2022
duckontheweb
force-pushed
the
fix/423-transactions-response
branch
from
d4a38ab to
7f58035
Compare
duckontheweb
added a commit
that referenced
this pull request
Aug 1, 2022
duckontheweb
force-pushed
the
fix/423-transactions-response
branch
from
f7916fd to
040d930
Compare
geospatial-jeff
approved these changes
Aug 1, 2022
duckontheweb
force-pushed
the
fix/423-transactions-response
branch
from
040d930 to
e06bbdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Updates
stac_fastapi.pgstac.transactions.TransactionsClientto return the Item or Collection from the Transactions endpoints as it would appear in a subsequentGETcall. This means thatselfandrootlinks point to the API rather than the original HREFs provided in the request.I did not see any places where the documentation needed updating, but let me know if I missed anything.
PR Checklist:
pre-commit run --all-files)make test)make docs)