Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media type for queryables endpoints #421

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jul 10, 2022

Related Issue(s):

Description:

Creates a new JSONSchemaResponse class with a application/schema+json media type that is used in the /queryables responses.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

Copy link
Collaborator

@geospatial-jeff geospatial-jeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@duckontheweb duckontheweb force-pushed the fix/400-queryables-content-type branch from 39303bd to 0d69e5b Compare July 21, 2022 20:38
@duckontheweb
Copy link
Contributor Author

@geospatial-jeff What's the convention for merging these PRs. Is there a maintainer who should do it, or is the author expected to merge them once they are approved?

@geospatial-jeff
Copy link
Collaborator

What's the convention for merging these PRs.

Honestly not sure, we should probably figure this out haha. Created #433

@geospatial-jeff geospatial-jeff merged commit 1faabd3 into master Jul 28, 2022
@geospatial-jeff geospatial-jeff deleted the fix/400-queryables-content-type branch July 28, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content type of /queryables endpoint is application/json instead of application/schema+json
3 participants