Change of datetime type in BaseSearchGetRequest + test improvement #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #315
Description:
This closes #315 . I made a minor change to fix that issue of removing
Dict
as a type option fordatetime
inBaseSearchGetRequest
after a lot of investigation to determine it doesn't ever appear as aDict
downstream. Most of the PR includes expansion of the existing tests.The current tests weren't catching the issue described in #315 for a couple reasons: 1) some of the tests were testing too many things at once. For example, the temporal tests targeted at a
datetime
search, also included abbox
orintersects
parameter; and 2) in many of the tests, only one item was being added to the test collection and then searched so when a parameter wasn't properly filtering the results (like in this case), it wasn't being caught.PR Checklist:
pre-commit run --all-files
)make test
)make docs
)