Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of datetime type in BaseSearchGetRequest + test improvement #318

Merged
merged 11 commits into from
Jan 12, 2022

Conversation

zstatmanweil
Copy link
Contributor

@zstatmanweil zstatmanweil commented Jan 11, 2022

Related Issue(s): #315

Description:
This closes #315 . I made a minor change to fix that issue of removing Dict as a type option for datetime in BaseSearchGetRequest after a lot of investigation to determine it doesn't ever appear as a Dict downstream. Most of the PR includes expansion of the existing tests.

The current tests weren't catching the issue described in #315 for a couple reasons: 1) some of the tests were testing too many things at once. For example, the temporal tests targeted at a datetime search, also included a bbox or intersects parameter; and 2) in many of the tests, only one item was being added to the test collection and then searched so when a parameter wasn't properly filtering the results (like in this case), it wasn't being caught.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@zstatmanweil zstatmanweil changed the title Get request bug tests Change of datetime type in BaseSearchGetRequest + test improvement Jan 11, 2022
@bitner
Copy link
Collaborator

bitner commented Jan 11, 2022

Thanks for all the tests @zstatmanweil ! This looks good to me.

@moradology moradology merged commit 93debff into stac-utils:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetime no longer a parameter option in GET /search
3 participants