Allow custom models for search GET and items endpoints #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I use a different default limit than this project, which is 10. While currently you can override the
search_request_model
in the StacApi class, you can't do so for the models that give default values to the item collection endpoint and the GET search. This PR adds models that allow users to override these types. It also contains the ability for the pgstac backend to use a custom search model instead of building a PgstacSearch for the item collection and GET search endpoints. I made this change while tracking down why my overridden limit was not being used; this turns out not being needed for my specific use case (as the default limit comes from the arguments passed into the core client methods by ItemCollectionUri and SearchGetRequest), it seemed like a sensible change in case any other user would want to modify the behavior of the search model in more than just the search POST endpoint.PR Checklist:
pre-commit run --all-files
)make test
)make docs
)