Correct response codes for bad/unusable bboxes #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moradology
force-pushed
the
fix/search-bbox-400s
branch
from
62a7f4d to
8a410ae
Compare
moradology
force-pushed
the
fix/search-bbox-400s
branch
from
8a410ae to
c90526d
Compare
lossyrob
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents 500s from being sent back to the user when parameters (BBox in particular, but it should help with others) are misconfigured. 400s should now be returned if users attempt a search with invalid bounding boxes. 501s will be returned for 6-length (not yet supported, 3D) bounding boxes.
Closes #222