Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove shapely from requirement in stac_fastapi.pgstac #225

Merged
merged 3 commits into from
Aug 12, 2021
Merged

remove shapely from requirement in stac_fastapi.pgstac #225

merged 3 commits into from
Aug 12, 2021

Conversation

vincentsarago
Copy link
Member

closes #224

@kylebarron
Copy link
Contributor

kylebarron commented Aug 11, 2021 •
edited
Loading

Looks like it's used in the test suite?

stac-fastapi/stac_fastapi/pgstac/tests/resources/test_item.py

Line 9 in 9ef8601

from shapely.geometry import Polygon

You might need to add it to the tests_requires

@vincentsarago
Copy link
Member Author

🙏 @kylebarron

bitner
bitner approved these changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@bitner bitner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lossyrob lossyrob merged commit e6c8e26 into stac-utils:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lossyrob lossyrob lossyrob approved these changes

@bitner bitner bitner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove shapely from requirements
4 participants
@vincentsarago @kylebarron @bitner @lossyrob