-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable conformance class configuration #214
Enable conformance class configuration #214
Conversation
I just ran this against the STAC API Validator and is passed the conformance part of the tests (though it blows up because the /collections endpoint is wrong) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! There will be some merge conflicts due to #199
@moradology In the filter extension PR, I added a method |
nice! |
@rsmith013 I like the idea of separating base conformance classes from those which are clearly extensions but am not entirely sold on not making the base classes configurable (I could be convinced but wonder how many not-fully-compliant STACs are out there). I've added the behavior from your PR though, as it looks like a win |
Sounds good - @moradology can you update to latest and then I'll merge? |
1c86dd5
to
745c111
Compare
745c111
to
d0939bc
Compare
98dd362
to
353935e
Compare
@lossyrob Pinging you so that you can push the button. Should be good to go |
This PR adds a
conformance_classes
parameter to theLandingPageMixin
and all clients downstream fromBaseCoreClient
orAsyncCoreClient
. This feature was added in a prior commit but appears to have been lost in the shuffle - a test has been added to hopefully avoid the regression going forward.Closes #169