Allow for linting in-memory dictionaries #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
approved these changes
Nov 28, 2022
gadomski
requested changes
Nov 28, 2022
tests/test_lint.py
Outdated
| assert linter.valid_stac == True | ||
| assert linter.asset_type == "COLLECTION" | ||
| assert linter.check_catalog_id_file_name() == False | ||
| assert linter.create_best_practices_dict()["check_catalog_id"] == ["Object should be called 'collection.json' not 'simple-collection.json'"] |
There was a problem hiding this comment.
Collections usually have descriptive IDs, e.g. https://planetarycomputer.microsoft.com/api/stac/v1/collections/sentinel-2-l2a. I think this lint is incorrect.
There was a problem hiding this comment.
This project was an attempt to follow the STAC Best Practices document. I think in the document this advice is only for static catalogs? https://github.com/radiantearth/stac-spec/blob/master/best-practices.md#static-catalogs
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for this. I'm changing the check so that it only activates with a static file.
gadomski
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#91