Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.4.0 #111

Merged
merged 12 commits into from
Oct 9, 2024
Merged

Update 1.4.0 #111

merged 12 commits into from
Oct 9, 2024

Conversation

jonhealy1
Copy link
Collaborator

@jonhealy1 jonhealy1 commented Oct 9, 2024

@jonhealy1 jonhealy1 marked this pull request as ready for review October 9, 2024 04:07
@jonhealy1 jonhealy1 requested a review from gadomski October 9, 2024 04:14
@jonhealy1
Copy link
Collaborator Author

jonhealy1 commented Oct 9, 2024

@gadomski Hi. Let me know if you don't have time to look at this. Also, I need access to the settings tab in this repo so I can add the token for PyPI to set up publishing via gh actions.

@gadomski
Copy link
Member

gadomski commented Oct 9, 2024

Hi. Let me know if you don't have time to look at this.

👋🏼 Hey @jonhealy1, it might take me a little bit to get to, but happy to take a look. FWIW I don't really use stac-check in any of my stacks, so if there's someone else that does use it, they might be a good person to review as well.

I need access to the settings tab in this repo so I can add the token for PyPI to set up publishing via gh actions.

No issues w/ giving you admin, but FWIW I've moved to using trusted publishing in other repos (e.g. pystac in this last release: https://github.com/stac-utils/pystac/pull/1414/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34). Trusted publishing lets Github Actions push to PyPI without any tokens, which is quite nice. I'd recommend looking at that first, and only falling back to tokens if that doesn't work for some reason. I see that you appear to be the (sole) maintainer at https://pypi.org/project/stac-check/, so you shouldn't have any issues configuring things from the PyPI side.

@jonhealy1
Copy link
Collaborator Author

@gadomski All good. I will try to set up trusted publishing. It would probably be good to be an admin here if you have time. Thank you

@gadomski
Copy link
Member

gadomski commented Oct 9, 2024

It would probably be good to be an admin here if you have time.

Done 🙇🏼

@jonhealy1
Copy link
Collaborator Author

Tanks!

@jonhealy1 jonhealy1 merged commit b3f2597 into main Oct 9, 2024
6 checks passed
@jonhealy1 jonhealy1 deleted the update-1.4.0 branch October 9, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants