-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update raster extension to v1.1.0 #809
Conversation
- update schema uri - align nodata type with new schema: change nodata type from float to union of float and a StringEnum, where the StringEnum contains "nan", "inf", and "-inf" - update tests
Codecov Report
@@ Coverage Diff @@
## main #809 +/- ##
=======================================
Coverage 94.32% 94.33%
=======================================
Files 83 83
Lines 11885 11897 +12
Branches 1388 1389 +1
=======================================
+ Hits 11211 11223 +12
Misses 495 495
Partials 179 179
Continue to review full report at Codecov.
|
In this case, the only change between v1.0.0 and v1.1.0 is the allowance of certain strings for the However, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjhartzell Thanks so much for working on this, these changes all look good to me. Your comment on the migration only needing to update the schema URI is right on, so I think this is ready to be converted from Draft to PR and merged.
@pjhartzell Any objection to me converting this from a Draft? |
No objection to convert from Draft. Thanks for taking a look. |
Related Issue(s): #789
Description:
Makes "nan", "inf", and "-inf" valid values for the
nodata
property inraster:bands
.nodata
type with the updated schema, which allows for numeric and "nan", "inf", and "-inf" strings.raster:bands
object added to theB09
asset is from the sentinel example in the Raster Extension repo.PR Checklist:
pre-commit run --all-files
)scripts/test
)