refactor: Avoid implicit re-exports in main module

[l0b0]

Related Issue(s): #332

Description: Work in progress until I resolve circular imports

PR Checklist:

• Code is formatted (run pre-commit run --all-files)
• Tests pass (run scripts/test)
• Documentation has been updated to reflect changes, if applicable
• This PR maintains or improves overall codebase code coverage.
• Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

[codecov-commenter]

Codecov Report

Merging #543 (1a02b9f) into main (f2afd5a) will increase coverage by 0.00%.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          71       71           
  Lines       10269    10272    +3     
  Branches     1072     1072           
=======================================
+ Hits         9679     9682    +3     
  Misses        422      422           
  Partials      168      168           

Impacted Files	Coverage Δ
pystac/collection.py	93.46% <90.00%> (+0.02%)	⬆️
pystac/item_collection.py	93.93% <92.85%> (+0.18%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2afd5a...1a02b9f. Read the comment docs.

[duckontheweb]

@l0b0 One thing to consider here is that clearing out the top-level __init__.py file would represent a breaking change since it would change the way all of our classes, etc. need to be imported. If that is the ultimate plan, we should probably get this in before a 1.0.0 release.

cc: @lossyrob

[lossyrob]

As a I mentioned in the other PR, I'm -1 on clearing out the top level of types.

I'm also -1 of making code quality refactors that modify the API at this point, as I think it will slow down a release, which is of higher value IMO.

[duckontheweb]

As a I mentioned in the other PR, I'm -1 on clearing out the top level of types.

I'm also -1 of making code quality refactors that modify the API at this point, as I think it will slow down a release, which is of higher value IMO.

I am in agreement, and based on this comment I believe @l0b0 is as well. If that is the case, and we are not going to make major changes to how users import classes and function from the top-level of PySTAC, then I don't think we need to rush to get this into the 1.0 release.