refactor: Use stricter mypy configuration #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only for the two libraries for which it's necessary. See <https://mypy.readthedocs.io/en/latest/command_line.html#cmdoption-mypy-ignore-missing-imports>.
Codecov Report
@@ Coverage Diff @@
## main #537 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 71 71
Lines 10302 10302
Branches 1072 1072
=======================================
Hits 9704 9704
Misses 430 430
Partials 168 168 Continue to review full report at Codecov.
|
duckontheweb
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #332
Description: This is almost as strict as
strict = True, which can replace every strictness setting already in place once we fulfillno_implicit_reexport = True, which I'll try to do in a separate PR since we need to resolve import cycles to do it.PR Checklist:
pre-commit run --all-files)scripts/test)