Ensure correct url format from local files #271
Conversation
fixed to avoid issues with test paths
| @@ -521,6 +522,7 @@ def from_file(cls, href): | |||
| """ | |||
| if not is_absolute_href(href): | |||
| href = make_absolute_href(href) | |||
| href = f"file:{pathname2url(href)}" | |||
There was a problem hiding this comment.
This breaks tests - perhaps a better approach would be to put this line directly in the STAC_IO method you point to in the body of the PR?
There was a problem hiding this comment.
Let me try to work out a different way of doing this. In my case, all test pass with this fix, so I guess the behaviour in the CI and in my machine (or any windows machine, for that matter), might be different.
|
Hm, we've had issues with Windows paths in the past, but I thought we got past that. I don't believe this is broken for all cases of windows paths; maybe it's possible to put up a unit test that shows the problem, even when running on non-windows OS's? We use ntpath to test in unit tests, although there's an issue around using a different technique which isn't implemented yet. |
|
I don't think that npath is the problem or affects this. The issue is with the path starting with the drive name and a colon (C:). With that, urlopen (in the line that i pointed out) understands that the drive name is the protocol of the url, and raises the exception. So the paths are correctly formed, that works fine, but without the "file://" prefix urlopen does not work. |
|
Gotcha. Perhaps the case with a drive prefix can be handled prior to the https://github.com/stac-utils/pystac/blob/develop/pystac/stac_io.py#L19 line instead of how it's currently implemented to avoid the unit test failure. |
|
@volaya I got the Windows CI builds running properly in #361 and noticed this issue as well. I solved it there by using There still appear to be a number of other path-related issues on Windows, so I opened up #362 to track fixing the rest of those. |
Not sure if others are having the same problem or I am missing something, but without this fix all tests fail in Windows.
The reason for it is in here:
https://github.com/stac-utils/pystac/blob/develop/pystac/stac_io.py#L19
The urlopen function does not understand a windows path such as
c:\folder\file.ext, and raises an exception.