Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update datacube extension #1269

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Update datacube extension #1269

merged 4 commits into from
Oct 23, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 18, 2023 •
edited
Loading

Related Issue(s):

Description:

Includes migration work and adding the VectorSpatialDimension.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell October 18, 2023 22:06
@gadomski gadomski self-assigned this Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pystac/extensions/datacube.py 77.99% <69.76%> (-1.19%) ⬇️

📢 Thoughts on this report? Let us know!.

@gadomski gadomski force-pushed the issues/856-datacube branch from cec0386 to e091ef0 Compare October 20, 2023 13:43
jsignell
jsignell approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gadomski gadomski added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 10cb05d Oct 23, 2023
19 checks passed
@gadomski gadomski deleted the issues/856-datacube branch October 23, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DataCube Extension to the latest version (support in assets)
2 participants
@gadomski @jsignell