Update version extension #1262
Merged
Update version extension #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
issues/1257-version-extension
branch
from
37282b3 to
8bf6cdc
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
jsignell
reviewed
Oct 16, 2023
jsignell
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Implement version v1.2.0. Most of it was easy, except for the whole "assets can't have links" part. That I implemented by splitting the extension functionality into
BaseVersionExtension, which doesn't have link stuff, andVersionExtension, which inherits and does. Should be non-breaking?Apologies for the diff explosion -- I couldn't resist updating import styles to align with #1259 when I saw the chance.
PR Checklist:
pre-commithooks pass locallyscripts/test)