Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin jsonschema to <4.18 in validation and test #1192

Merged

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

Description:

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@philvarner philvarner requested a review from gadomski July 17, 2023 14:40
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4780f55) 92.01% compared to head (69ad6cb) 92.01%.

❗ Current head 69ad6cb differs from pull request most recent head e42f107. Consider uploading reports for the commit e42f107 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1192   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          51       51           
  Lines        6809     6809           
  Branches     1007     1007           
=======================================
  Hits         6265     6265           
  Misses        368      368           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
@philvarner philvarner added this pull request to the merge queue Jul 18, 2023
Merged via the queue into stac-utils:main with commit ebe5c6b Jul 18, 2023
@philvarner philvarner deleted the pv/set-test-dep-to-jsonschema-lt-4.18 branch July 18, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants