-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand support for multiple extension uris #1091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsignell
commented
Apr 10, 2023
gadomski
requested changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple light touchups.
gadomski
approved these changes
Apr 12, 2023
5 tasks
jpolchlo
added a commit
to jpolchlo/pystac
that referenced
this pull request
May 22, 2023
jpolchlo
added a commit
to jpolchlo/pystac
that referenced
this pull request
May 23, 2023
jpolchlo
added a commit
to jpolchlo/pystac
that referenced
this pull request
May 25, 2023
jpolchlo
added a commit
to jpolchlo/pystac
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
From issue:
I looked over the merged PRs from the last year or so to try to get a sense of which extensions had gotten updates recently.
I also added the previous versions to the
prev_extension_ids
in theExtensionHooks
. This means that when the item is migrated, the extension schema uri gets updated as well. Note: It looks like there is a mechanism for migrating per-extension. You can see it inLabelExtensionHooks.migrate
PR Checklist:
pre-commit
hooks pass locallyscripts/test
)