Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run continuous integration tests when code is changed in the src directory as well #322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mishaschwartz
Copy link

@mishaschwartz mishaschwartz commented Nov 19, 2024

This fixes #321 by building new docker images when any of the relevant files have changed (not just the ones in the docker/ directory.

Tests will run if either of the images are built which indicates that the code has changed in a way that requires testings. If neither images are built, this means that the testable code has not changed and the tests will not run.

This PR also fixes some errors reported by mypy and ruff while running the tests.

Note that this PR does not fix a failing pytest test since there is a discussion about how best to resolve it here: developmentseed/hydraters#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous integration should run tests more often
1 participant