Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuous integration should run tests more often #321

Open
mishaschwartz opened this issue Nov 19, 2024 · 0 comments · May be fixed by #322
Open

Continuous integration should run tests more often #321

mishaschwartz opened this issue Nov 19, 2024 · 0 comments · May be fixed by #322

Comments

@mishaschwartz
Copy link

Tests are run in CI if changes are detected and if both the pg and pyrust docker images are built:

pgstac/.github/workflows/continuous-integration.yml

Lines 101 to 103 in 6c569c0

test:
name: test
needs: [changes, buildpg, buildpyrust]

But these images are only built if there are changes made to the docker directory:

pgstac/.github/workflows/continuous-integration.yml

Lines 28 to 35 in 6c569c0

- uses: dorny/paths-filter@v2
id: filter
with:
filters: |
pgstac:
- 'docker/pgstac/**'
pypgstac:
- 'docker/pypgstac/**'

even though the image also depends on some files in the src/ directory.

This means that any changes to the src/ directory will not be tested in the CI pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mishaschwartz