Deprecate product_uri and reflectance_conversion_factor #2 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
reviewed
May 29, 2024
| @@ -726,7 +725,6 @@ | |||
| "s2:not_vegetated_percentage": 0.000708, | |||
| "s2:degraded_msi_data_percentage": 0, | |||
| "s2:high_proba_clouds_percentage": 0.699942, | |||
| "s2:reflectance_conversion_factor": 1.01678413954947, | |||
There was a problem hiding this comment.
Is there a different key that we should be using for this value? Feels strange to lose information and not just move it to a different key.
There was a problem hiding this comment.
No, ESA removes it without replacement. It seems not relevant to the general public.
There was a problem hiding this comment.
🤔 strange — it's documented in https://sentinels.copernicus.eu/documents/247904/0/Sentinel-2-product-specifications-document-V14-9.pdf so seems unusual to want to remove it. I guess I'm -0.
There was a problem hiding this comment.
That's what ESA came up with in recent calls. We should probably wait for the official release of the CDSE STAC API anyway before we merge this.
gadomski
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely more controversial than the other deprecated fields, but in discussions with ESA around their official STAC catalog (CDSE) for Sentinel-2, it was decided to not deliver these two fields in the official STAC catalog in the future. Thus I'd say we could also deprecate it here.