Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uri-js dependency #35

Closed
wants to merge 2 commits into from
Closed

Add uri-js dependency #35

wants to merge 2 commits into from

Conversation

jamesfisher-geo
Copy link
Collaborator

The stac-node-validator step in the test had started to fail with the error:

> [email protected] check-examples
> stac-node-validator . --lint --verbose --schemaMap https://stac-extensions.github.io/authentication/v1.1.0/schema.json=./json-schema/schema.json

node:internal/modules/cjs/loader:1042
  throw err;
  ^

Error: Cannot find module 'uri-js'
Require stack:
- /mnt/c/Users/james/Documents/github/authentication/node_modules/stac-node-validator/iri.js
- /mnt/c/Users/james/Documents/github/authentication/node_modules/stac-node-validator/index.js
- /mnt/c/Users/james/Documents/github/authentication/node_modules/stac-node-validator/bin/cli.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1039:15)
    at Module._load (node:internal/modules/cjs/loader:885:27)
    at Module.require (node:internal/modules/cjs/loader:1105:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/mnt/c/Users/james/Documents/github/authentication/node_modules/stac-node-validator/iri.js:1:19)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at Module.load (node:internal/modules/cjs/loader:1081:32)
    at Module._load (node:internal/modules/cjs/loader:922:12)
    at Module.require (node:internal/modules/cjs/loader:1105:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/mnt/c/Users/james/Documents/github/authentication/node_modules/stac-node-validator/iri.js',
    '/mnt/c/Users/james/Documents/github/authentication/node_modules/stac-node-validator/index.js',
    '/mnt/c/Users/james/Documents/github/authentication/node_modules/stac-node-validator/bin/cli.js'
  ]
}

Node.js v18.13.0

Adding uri-js as a dependency resolves the issue. I am not sure what introduced this bug.

@jamesfisher-geo jamesfisher-geo requested a review from m-mohr June 4, 2024 07:52
@jamesfisher-geo
Copy link
Collaborator Author

This issue might be affecting other extension repos. I posted in gitter here: https://matrix.to/#/!keYKZtlQXulQARQNzG:gitter.im/$lsKfGEX86-euBc41lfCpp1IW8vS0qy73BR7RSEYexbg?via=gitter.im&via=matrix.org&via=chard.com

@m-mohr
Copy link
Contributor

m-mohr commented Jun 4, 2024

Let me check this on the Validator side... :)

@m-mohr m-mohr self-assigned this Jun 4, 2024
@m-mohr
Copy link
Contributor

m-mohr commented Jun 4, 2024

The dependency was missing in the validator, I've released a v1.3.1 bugfix release. This PR shouldn't be needed any longer.

@jamesfisher-geo
Copy link
Collaborator Author

The dependency was missing in the validator, I've released a v1.3.1 bugfix release. This PR shouldn't be needed any longer.

Nice, thank you!

@m-mohr
Copy link
Contributor

m-mohr commented Jun 4, 2024

I also just reran the failed jobs and they don't fail any longer.

@m-mohr m-mohr closed this Jun 4, 2024
@m-mohr m-mohr deleted the validator branch June 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants