Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overhaul] Implementation of a more consistent & modern UI #899

Merged
merged 48 commits into from
Mar 20, 2024

Conversation

KyleKlus
Copy link
Contributor

@KyleKlus KyleKlus commented Mar 11, 2024

Description

This PR is an overhaul of the main ui and it implements the issue #872. More detail on what the PR implements and more documentation in general can be found there.

Changes

…ay of showing/hiding without the need of rerendering everything
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution! Looks like there are some conflicts since some of the changes are reverting things that have already gone in

manifest.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
@KyleKlus KyleKlus requested a review from st3v3nmw March 14, 2024 20:19
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Please resolve the merge conflicts (caused by merging #902)

@KyleKlus
Copy link
Contributor Author

I think this PR also fixes the bug in issue #768, as I've changed the mobile view such that this shouldn't be a problem anymore, but I don't have a IOS device, so I can't test it.

@st3v3nmw st3v3nmw merged commit d4b8d01 into st3v3nmw:master Mar 20, 2024
1 check passed
@SimoAbjaou
Copy link

Hello, can you please see this ticket : #1101
Can you help me the fix it ?

@KyleKlus
Copy link
Contributor Author

Sry I think I cant help you here, but I haven't changed anything in regards with how the markdown is rendered. I just transformed the containers around the markdown rendered content. Thus I couldn't have changed anything how an Image is rendered.

@KyleKlus KyleKlus deleted the ui-overhaul branch November 17, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants